Fluid pipes 1+ L bug

Support & Questions & Bugs & Help & Requests
1

Some pipe sections don’t become empty when they really should.
Happens since fix for:
[FIXED] Insanely large Capacity Pipes had Integer Overflow Issues.

Sometimes pipe has more than 1 liter of fluid in a section. I noticed that this problem is mostly with corners.

Example: diesel engine, fed by a drum through pipe. Petrol goes from drum down 1 pipe, right 1 pipe, then into diesel engine (1 corner pipe, 1 straight). I remove drum, then repeatedly drain diesel engine (through tap) until it becomes empty. Corner pipe has 1 liter of petrol…

2 Likes
2

You happen to have an annotated screenshot (as in draw on it with GIMP or MS Paint or whatever XD)

1 Like
3

2020-12-02_20.02.07
2020-12-02_20.02.07854×480 283 KB

2 Likes
4

Wait that looks like you wrenched it up with an empty thing above, maybe it tries to fill whatever is above? What happens if you remove the upwards facing?

1 Like
5

Nothing. I tried two ways:

  1. remove drum, drain (through engine), remove upwards facing
  2. remove drum, remove upwards facing, drain.
2 Likes
6

You know the deal, please try this. ^^


:gregory: This Version should probably be working for you. ^^

(note 1: The scary sounding Description is only there to make sure people don’t use that Version lightly.)

(note 2: if you use this Version more often, make sure your Browser didn’t cache the Download)

1 Like
7

2020-12-03_08.38.43
2020-12-03_08.38.43854×480 142 KB

These all are large bronze pipes (capacity 900). At first measurements some of these pipes had 901 liters (324 one really had).
Feels like liquids now move much slower through pipes, drums, etc.

2 Likes
8

Okay, please try again with yet another new Snapshot Version. The Fluid flow definitely must’ve changed because I removed the “Backflow Stopper” from Pipe->Pipe interactions (its still in there for Tank->Pipe->Tank Interactions)

Though please wait 10 mins from the time i posted this.
It did not compile yet and I’ve hit send too soon. XD

Edit: It should be up now.

1 Like
9

Gah, you showed up while I was afk, would you please give me the location of the Nullpointer Exception, you should know that I need that…

1 Like
10

java.lang.NullPointerException
at gregapi.tileentity.connectors.MultiTileEntityPipeFluid.distribute(MultiTileEntityPipeFluid.java:327)
at gregapi.tileentity.connectors.MultiTileEntityPipeFluid.onServerTickPre(MultiTileEntityPipeFluid.java:270)
at gregapi.GT_API_Proxy.onServerTick(GT_API_Proxy.java:363)
at cpw.mods.fml.common.eventhandler.ASMEventHandler_13_GT_API_Proxy_onServerTick_ServerTickEvent.invoke(.dynamic)
at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54)
at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140)
at cpw.mods.fml.common.FMLCommonHandler.onPreServerTick(FMLCommonHandler.java:260)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:536)
at fastcraft.at.a(F:978)
at fastcraft.H.aq(F:36)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:396)
at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:685)

2 Likes
11

Oops, used the wrong variable when copypasting. Anyways, its committed and pushed again.

1 Like
12

No more crashes, but still 1L+ problems. Also, drum doesn’t output liquid sodium down to pipe.

2 Likes
13

Maybe it outputs. Pipe section below drum is exactly full, each other pipe is less and less full.

2 Likes
15

Okay I finally managed to fix it (I also tested it), please test it with your Setups now. ^^

1 Like
16

testing… 1L petrol problem no longer exists. I have to make more complex tests.

2 Likes